Gradients - From Terminal Text Effects

[tznind]

I have started looking at Terminal Text Effects python library and did some experimental porting with some Chat GPT help.

I've switched to our Color scheme and Point but the rest is largely unchanged.

Also found a bug in LineCanvas intersections coordinates being wrong on the data model (not actually affecting rendering but came up as I tested the gradient mapping logic).

I initially started porting everything but it got a bit out of hand. This is just the gradient class ported and a showcase.

Fixes

• Fixes #_____

Proposed Changes/Todos

• No nested classes
• Tests
• xmldoc

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[tig]

This could be leveraged for

• Revamp ColorPicker and Color Scenarios in UICatalog #2800

[tznind]

This could be leveraged for #2800

Yup we could definetly do some kind of color wheel/rectangle thing

Any idea why CI tests are aborting with?

The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.ArgumentException: There is at least one object in this array that cannot be serialized (Parameter 'array')

[tig]

FYI - your tests may be failing because of work i'm doing on trying to fix #3052. JFYI

[tig]

The github action is back to just running on Windows, so you can merge with v2_develop and try again. Sorry about all this.

[tznind]

This is good to go to review, I will look into color picker but that can be seperate PR.

[tig]

This is good to go to review, I will look into color picker but that can be seperate PR.

I have an old pr for that already. Happy to have you contribute to it.

[tig]

See my comments. This is lovely.

[tig]

It'd be cool if TextFormatter had the equivalent of LineCanvas.FillPair, no?

[tig]

It'd also be killer for ProgressBar to have a gradient style:

[tig]

PR incoming that does this:

[tig]

tznind#165

[tig]

LGTM!

[tig]

Do you think this is ready to merge @tznind. I do.

[tznind]

Yup good to go!

I looked at TextFormatter but looks non trivial. Can investigate in another pr but I might look to do HSL style true color picker first.

I also want to look at what else text effects has that we could port.

[tig]

@tznind please confirm you received email with reshaper license.

[tznind]

Got it thanks!

…

On Wed, 10 Jul 2024, 16:05 Tig, ***@***.***> wrote: @tznind <https://github.com/tznind> please confirm you received email with reshaper license. — Reply to this email directly, view it on GitHub <#3586 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHO3C5B4IPO6WFTM5YMOU7DZLVES7AVCNFSM6AAAAABKPHJ7SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQG42TONBUHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>