Fixes #3229. TextFormatter should have a FillRemaining property.

[BDisp]

Fixes

• Fixes TextFormatter should have a FillRemaining property. #3229

Proposed Changes/Todos

• Add FillRemaining property
• Allow pass the property as parameter to the TextFormatter?.Draw
• Add unit test

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[tig]

Unless i'm missing something, I think this PR can be simplied per my comments.

[tig]

TextFormatter.Draw is an instance method. It is silly to have BOTH a fillRemaining parameter AND an instance property that do the same thing.

I suggest:

• Add FillRemaining as a property
• Remove the fillRemaining parameter from Draw
• Have Draw reference FillRemaining where it currently references fillRemaining

Make sense?

[BDisp]

TextFormatter.Draw is an instance method. It is silly to have BOTH a fillRemaining parameter AND an instance property that do the same thing.

I suggest:

• Add FillRemaining as a property
• Remove the fillRemaining parameter from Draw
• Have Draw reference FillRemaining where it currently references fillRemaining

Make sense?

Yes it makes sense, but you didn't answer about the default property value. Do you agree with this?

public bool FillRemaining { get; set; } = true;

[tig]

TextFormatter.Draw is an instance method. It is silly to have BOTH a fillRemaining parameter AND an instance property that do the same thing.
I suggest:

• Add FillRemaining as a property
• Remove the fillRemaining parameter from Draw
• Have Draw reference FillRemaining where it currently references fillRemaining

Make sense?

Yes it makes sense, but you didn't answer about the default property value. Do you agree with this?

public bool FillRemaining { get; set; } = true;

I'm not sure. The call in View.OnDrawContent, Thickness.Draw, etc... specify false. That's because we need to minimize how much default drawing we're doing for perf reasons. If the background was already drawn, there's no need to make it true.

So, I guess I'd pick false as the default`.

[BDisp]

The difference is like bellow:

If FillRemaining is false:

If FillRemaining is true:

The advantage of true is when we need to draw the focused color even on empty strings. For labels isn't affected because they aren't focused. I'll set as false by default then.