Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making scala-steward able to update deps for unlinked *Sample projects #664

Merged

Conversation

blast-hardcheese
Copy link
Member

I read through scala-steward in order to figure out why library upgrades for sample subprojects weren't getting opened.

It turns out it's because the stewardDependencies task walks libraryDependencies for root and aggregated tasks.

Unfortunately, as *Sample projects are not designed to be aggregated (they don't pass compile unless we're running testSuite), it necessitated some hoop jumping.

A more long-term solution would be to modify scala-steward to be able to run the stewardPlugin against non-root projects, but as this is a fairly niche use case, I'm OK with this solution for now.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@blast-hardcheese blast-hardcheese force-pushed the liberating-dependencies branch from 935aa93 to 86a08f9 Compare June 14, 2020 03:21
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2020

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files          78       78           
  Lines        5163     5163           
  Branches      130      130           
=======================================
  Hits         4189     4189           
  Misses        974      974           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e0a5e...96fcd6e. Read the comment docs.

@blast-hardcheese blast-hardcheese force-pushed the liberating-dependencies branch from 86a08f9 to 96fcd6e Compare June 14, 2020 03:57
@blast-hardcheese blast-hardcheese merged commit 9810a57 into guardrail-dev:master Jun 14, 2020
@blast-hardcheese blast-hardcheese deleted the liberating-dependencies branch June 14, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants