Making scala-steward able to update deps for unlinked *Sample projects #664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read through scala-steward in order to figure out why library upgrades for sample subprojects weren't getting opened.
It turns out it's because the
stewardDependencies
task walkslibraryDependencies
for root and aggregated tasks.Unfortunately, as
*Sample
projects are not designed to be aggregated (they don't passcompile
unless we're runningtestSuite
), it necessitated some hoop jumping.A more long-term solution would be to modify scala-steward to be able to run the
stewardPlugin
against non-root
projects, but as this is a fairly niche use case, I'm OK with this solution for now.Contributing to Twilio