Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path matcher before method matcher in Akka HTTP routes. #644

Conversation

dvgica
Copy link

@dvgica dvgica commented May 26, 2020

This addresses #643 I believe.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@dvgica
Copy link
Author

dvgica commented May 26, 2020

Ah, I ran tests locally but apparently not all. I will work on fixing the failures.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #644 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files          78       78           
  Lines        5085     5085           
  Branches      130      130           
=======================================
  Hits         4110     4110           
  Misses        975      975           
Impacted Files Coverage Δ
...ail/generators/Scala/AkkaHttpServerGenerator.scala 91.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44caa32...cb02686. Read the comment docs.

Copy link
Member

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blast-hardcheese blast-hardcheese merged commit 4ad119f into guardrail-dev:master Jun 6, 2020
@dvgica
Copy link
Author

dvgica commented Jun 7, 2020

Thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants