Thread through required/nullable state #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't yet do anything with the new value; the behavior is intentionally unchanged as of yet. It will be mostly up to the protocol generators to implement proper behavior.
91a13f9 to
fc44cd8
Compare
blast-hardcheese
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threads through the info necessary to fix #315 (though it does not actually attempt to fix it yet; current behavior is maintained).
Verified with a temp git repo in each of the
sample-*dirs that generated output remains unchanged with these commits.Note that the name of this branch lies, as I dropped the
always-camelsnakebit after submitting.Contributing to Twilio