Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy, Nexus & fringe device support #297

Closed
lukeswitz opened this issue May 20, 2018 · 2 comments
Closed

Galaxy, Nexus & fringe device support #297

lukeswitz opened this issue May 20, 2018 · 2 comments

Comments

@lukeswitz
Copy link
Collaborator

Issue Recap: Nexus, Galaxy & Fringe Device Issues

Description: Camera errors and trouble determining facing or angle using Nexus handsets. Caused by its use of facing and rotation to form what would normally be a 0 or 1. Throws error code -38 when starting the MediaRecorder. This bug renders the app useless as stated in previous issues.

Reproducing: Using Haven and attempting to switch cameras when not actively previewing from the MonitorActivity would cause the Camera.open() call to return a null camera instance.

Buggy Workarounds: Avoid setting the audio source and format in MediaRecorderActivity. Alternatively, encode using h.263 instead of .264. Remove extraneous file separator from the videoFile path if necessary. This will give you a video file but the dependency used to play it back is old. You have to then export it to view, could be a data limit thing.

Conclusions: Setting the cameraFacing variable isn’t possible using a device that doesn’t provide a simple 0,1 camera configuration. Once lost, the app will crash when called a second time. For instance, when visiting MonitorView -> Settings -> Camera Sensitivity the parameters are attempting to be set on a null object after the Camera.open() call fails due to lack of a provided variable corresponding to the camera of the device.

  • Causes video monitoring to crash when setting the audio output and encoder because media recorder is already active at that time from an outside process using the microphone
  • Camera sensitivity in settings will crash if not accessed directly from the MonitorView
  • Modification may help some devices and hurt others, further testing required.
@n8fr8 n8fr8 modified the milestones: Next Sprint, Current Sprint Jul 2, 2018
n8fr8 added a commit that referenced this issue Jul 3, 2018
- uses the https://github.com/siralam/CameraViewPlus library to make the camera usage more reliable, and support Camera2
- integrates RenderScript support to move to better performance on some image conversion functions
- improves display and performance of detection display overlay
@lukeswitz
Copy link
Collaborator Author

e0ecdc6 fixes most all of this 👍 thank you! Issues above regarding video recording and bind handlers are mentioned eleewhere: #313, #295. Closing it up

@lukeswitz
Copy link
Collaborator Author

Current mp4 encoding not working on nexus 4 & 5 causing no playback. BMP encoding seems to intensive for older devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants