Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI step for models script #130

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Add CI step for models script #130

merged 3 commits into from
Feb 4, 2025

Conversation

philmcmahon
Copy link
Contributor

What does this change?

To support this change in AMIgo guardian/amigo#1607 to download whisperx models, this PR adds a CI step to add a new riffraff project which deploys the download-models script to a bucket in the deploy tools account where AMIgo can access it.

See this discussion for the motivation to publish to S3 via riffraff guardian/amigo#1607 (comment)

With this change, if we want to make a change to the download model script, the steps are:

  • push to feature branch
  • use riffraff to deploy the investigations::transcription-service-whisperx-model-fetch project to CODE/PROD
  • If we deployed to CODE, update the 'stage' parameter set on the AMIgo recipe used for the whisperx workers to point at CODE
  • Bake an AMI - it will fetch the script we deployed with riffraff

How to test

I've tested this using AMIgo CODE

@@ -0,0 +1,17 @@
allowedStages:
- PROD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no CODE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops!

@philmcmahon philmcmahon merged commit c341312 into main Feb 4, 2025
5 checks passed
@philmcmahon philmcmahon deleted the deploy-models-script branch February 4, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants