Add /tmp volume to media download task container #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekehuntergreen
approved these changes
Feb 6, 2025
| }; | ||
| mediaDownloadTask.taskDefinition.addVolume(volume); | ||
| const tempVolume = { |
There was a problem hiding this comment.
might be worth a comment explaining why this is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
I've seen occasionaly failures in the media download service because yt-dlp yt-dlp needs to be able to write to the /tmp directory. In #114 I made the media export filesystem read only, allowing writes to a /media-download mounted volume. This PR adds an extra volume to support writing to /tmp.
How to test
I've tested this on CODE. As it doesn't happen every time it's hard to test properly but I think it's a fairly harmless change.