Don't throw an error if ffprobe fails - instead default to whisperx

guardian · Feb 24, 2025 · c8302cc · c8302cc
1 parent ae48da5
commit c8302cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/backend-common/src/ffmpeg.ts b/packages/backend-common/src/ffmpeg.ts
@@ -4,16 +4,18 @@ import { promisify } from 'node:util';
 
 const execPromise = promisify(exec);
 
-export const getFileDuration = async (filePath: string): Promise<number> => {
+export const getFileDuration = async (
+	filePath: string,
+): Promise<number | undefined> => {
 	const command = `ffprobe -i ${filePath} -show_entries format=duration -v quiet -of csv="p=0"`;
 	try {
 		const { stdout, stderr } = await execPromise(command);
 		if (stderr) {
-			logger.error(` ffprobe stderr: `, stderr);
+			logger.error(`ffprobe stderr: `, stderr);
 		}
 		return parseFloat(stdout);
 	} catch (error) {
 		logger.error(`Error during ffprobe file duration detection`, error);
-		throw error;
+		return undefined;
 	}
 };
diff --git a/packages/backend-common/src/sqs.ts b/packages/backend-common/src/sqs.ts
@@ -70,7 +70,7 @@ export const generateOutputSignedUrlAndSendMessage = async (
 	languageCode: InputLanguageCode,
 	translationRequested: boolean,
 	diarizationRequested: boolean,
-	duration: number,
+	duration?: number,
 ): Promise<SendResult> => {
 	const signedUrls = await generateOutputSignedUrls(
 		s3Key,
@@ -81,7 +81,8 @@ export const generateOutputSignedUrlAndSendMessage = async (
 	);
 
 	const engine =
-		config.app.useWhisperx && (duration > 600 || diarizationRequested)
+		config.app.useWhisperx &&
+		(!duration || duration > 600 || diarizationRequested)
 			? TranscriptionEngine.WHISPER_X
 			: TranscriptionEngine.WHISPER_CPP;