feat: add checkout to addRegionIdToSupportUrl #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrf1
approved these changes
Sep 19, 2024
paul-daniel-dempsey
approved these changes
Sep 19, 2024
This has been fixed as it's a good thing to have picked up. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the URL
/checkoutto theaddRegionIdToSupportUrl.This needs to be done before we can merge guardian/dotcom-rendering#12403 that is moving from the generic checkout (
/contribute/checkout) to the generic checkout (/checkout).How to test
Tests are provided in the test suite.
This is used here in DCR.
How can we measure success?
We unblock the above mentioned PR.
Have we considered potential risks?
This is additive so should be good to go.
Images
Before code change
After code change