require users to have been granted the access permission to access the tool #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfurey
reviewed
Jan 15, 2025
Co-authored-by: David Furey <david.furey@guardian.co.uk>
bryophyta
approved these changes
Jan 21, 2025
|
Seen on PROD (merged by @andrew-nowak 6 minutes and 26 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Users should have been granted the access permission, in order to have permission to access the tool. Followup to #198 to enforce the permission.
How to test
Deploy to CODE, and try accessing the tool both with and without the correct permission. Are you prevented from accessing without the permission -- with a useful message for seeking assistance -- and allowed to access with the permission?