Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scala 3 support #81

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add Scala 3 support #81

merged 1 commit into from
Apr 12, 2024

Conversation

rtyley
Copy link
Member

@rtyley rtyley commented Mar 13, 2024

Here we're using Scala 3.3 LTS - all Scala libraries want to use LTS versions of Scala, to ensure the best levels of compatibility.

@rtyley rtyley force-pushed the add-scala-3-support branch from 56ccda4 to 381a28f Compare March 13, 2024 12:23
@rtyley rtyley requested a review from johnduffell March 15, 2024 18:07
johnduffell
johnduffell approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@johnduffell johnduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, nice tidyup too. I am impressed no source changes were needed to compile with scala 3!

@rtyley rtyley force-pushed the add-scala-3-support branch from 381a28f to 3857524 Compare April 12, 2024 15:47
@rtyley rtyley merged commit db61b6f into main Apr 12, 2024
1 check passed
@rtyley rtyley deleted the add-scala-3-support branch April 12, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnduffell johnduffell johnduffell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtyley @johnduffell