feat: add Scala release workflow #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
approved these changes
Mar 12, 2024
| commitNextVersion, | ||
| pushChanges | ||
| ) | ||
| scalacOptions := Seq("-release:11") |
There was a problem hiding this comment.
I like this, but do be aware that this will force any project using this library to upgrade to Java 11 (not a bad thing!).
We should be on Java 11 everywhere, but simple-configuration is used in a lot of places and it's possible some of them are still on Java 8! They really should upgrade...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds the Scala release workflow to allow for releasing to Sonatype via running a GH action.
How to test
Post-merge, run the release workflow as per the instructions.
How can we measure success?
This really improves the release process for this library, and should make it a lot easier to make a release.