Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding missing bracket #111

Merged
merged 1 commit into from
Feb 13, 2025
Merged

adding missing bracket #111

merged 1 commit into from
Feb 13, 2025

Conversation

johnduffell
Copy link
Member

@johnduffell johnduffell commented Feb 12, 2025

The code in the readme didn't compile due to a missing bracket. This PR fixes that.

I think there's a docs plugin that can make the code compile (and even run) in the docs, which would make sense for something like this. Tests are documentation after all!

@johnduffell johnduffell requested a review from a team as a code owner February 12, 2025 21:52
Copy link
Member

@kelvin-chappell kelvin-chappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnduffell johnduffell merged commit 555e9c2 into main Feb 13, 2025
1 check passed
@johnduffell johnduffell deleted the jd-readme-add-bracket branch February 13, 2025 09:39
@emdash-ie
Copy link
Contributor

I think there's a docs plugin that can make the code compile (and even run) in the docs, which would make sense for something like this.

That’d be really nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants