Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Java and sbt in dependency-graph workflow #522

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Install Java and sbt in dependency-graph workflow #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/sbt-dependency-graph.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,28 @@
name: Update Dependency Graph for SBT
name: Update Dependency Graph for sbt
on:
push:
branches:
- main
workflow_dispatch:
workflow_dispatch:
jobs:
dependency-graph:
runs-on: ubuntu-latest
steps:
- name: Checkout branch
id: checkout
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
- name: Install Java
id: java
uses: actions/setup-java@b36c23c0d998641eff861008f374ee103c25ac73 # v4.2.0
with:
distribution: corretto
java-version: 17
- name: Install sbt
id: sbt
uses: sbt/setup-sbt@8a071aa780c993c7a204c785d04d3e8eb64ef272 # v1.1.0
- name: Submit dependencies
Comment on lines -13 to +22
Copy link
Member

@rtyley rtyley Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - could we use guardian/setup-scala instead? This project already has .tool-versions file, and from @adamnfish's email on 4th December, DevX do plan to use guardian/setup-scala:

To summarise, we are replacing the standard actions/setup-java step with our own Guardian-managed guardian/setup-scala step. This new step installs Java and Scala (sbt) and simplifies the configuration of our runners by aligning with other parts of our tooling. In particular, the Java version is no longer provided directly in the workflow file. Instead, this comes from a .tool-versions file at the root of the repository.

I'm happy to make the changes (also following on from guardian/play-googleauth#275 & guardian/simple-configuration#103), just don't want to clash if there's a reason to go another way!?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it! I only didn't use it because the example I was copying from (raised by the dependency integrator bot) didn't use setup-scala – I don't have any strong feelings about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Looking at dates, the integrator bot raised the PR I copied from on the 2nd of December, so presumably it just predates the decision to use setup-scala)

id: submit
uses: scalacenter/sbt-dependency-submission@7ebd561e5280336d3d5b445a59013810ff79325e # v3.0.1
uses: scalacenter/sbt-dependency-submission@64084844d2b0a9b6c3765f33acde2fbe3f5ae7d3 # v3.1.0
- name: Log snapshot for user validation
id: validate
run: cat ${{ steps.submit.outputs.snapshot-json-path }} | jq
Expand Down
Loading