Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Play v2.8 #461

Closed
rtyley opened this issue May 24, 2024 · 2 comments
Closed

Dropping Play v2.8 #461

rtyley opened this issue May 24, 2024 · 2 comments

Comments

@rtyley
Copy link
Member

rtyley commented May 24, 2024

We've got limited Play v2.8 usage at the Guardian, so dropping Play v2.8 support may be a good way of fixing SNYK-JAVA-COMFASTERXMLJACKSONCORE-2421244:

✗ Denial of Service (DoS) [High Severity][https://security.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-2421244] in com.fasterxml.jackson.core:jackson-databind@2.11.4
    introduced by com.gu.play-secret-rotation:play-v28_2.13@8.3.1-SNAPSHOT > com.typesafe.play:play_2.13@2.8.21 > com.fasterxml.jackson.core:jackson-databind@2.11.4 and 13 other path(s)

Repos using play-v28 at the Guardian

https://github.com/search?q=org%3Aguardian+%22play-v28%22++NOT+is%3Aarchived&type=code

...this rough search shows only one specific use of "com.gu.play-secret-rotation" %% "play-v28":

...there is also only one use of "com.gu.play-googleauth" %% "play-v28":

cc @Divs-B

@mkurz
Copy link

mkurz commented May 24, 2024

btw, Play 2.8 will be EOL 31st of May, which is in 7 days. I will cut one last release with latest dependencies and that's it.
So good time to let go.

Divs-B added a commit that referenced this issue May 24, 2024
Let all others use Play version 3.

detail:#461
Divs-B added a commit that referenced this issue May 24, 2024
Let all others use Play version 3.

detail:#461
@rtyley
Copy link
Member Author

rtyley commented Sep 3, 2024

Done with #462

@rtyley rtyley closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants