-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'visited link' indicator #174
Open
bryophyta
wants to merge
6
commits into
main
Choose a base branch
from
pf/visited-link-indicator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryophyta
commented
Feb 24, 2025
@@ -51,7 +51,7 @@ export function urlToConfig(location: { | |||
} else if (page.startsWith('item/') && page.split('/').length === 2) { | |||
return { view: 'item', itemId: page.split('/')[1], query }; | |||
} else { | |||
console.warn(`Page not found: "${page}", so using defaultConfig`); | |||
console.log(`Page not found: "${page}", so using defaultConfig`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having this as a warn
was making the logs quite noisy when running tests. Given that we're not storing client-side logs in production, there doesn't seem much benefit to keeping this as a warn
, as opposed to a log
.
5711e85
to
c98d263
Compare
c98d263
to
6eb8d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
nb. I looked at using the
:visited
pseudo-selector for this styling, to make use of the browser's built-in behaviour. However, this selector matches on the whole URL, including search params, which doesn't work for our purposes, because we don't want to treat/item/123?search=a
as a separate page from/item/123?search=b
. (The styling is meant ot indicate that you've viewed item 123.)How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility