Set up stage-specific config #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3763b65 to
c398929
Compare
c398929 to
cc0bce3
Compare
kelvin-chappell
commented
Feb 5, 2024
| "net.logstash.logback" % "logstash-logback-encoder" % "7.3", | ||
| ("com.gu" %% "simple-configuration-ssm" % "1.6.4").cross(CrossVersion.for3Use2_13), |
There was a problem hiding this comment.
There's no Scala 3 version of the library yet
kelvin-chappell
commented
Feb 5, 2024
| @@ -34,7 +34,7 @@ export class Gatehouse extends GuStack { | |||
| userData: { | |||
| distributable: { | |||
| fileName: `${ec2App}.deb`, | |||
| executionStatement: `dpkg -i /${ec2App}/${ec2App}.deb && echo "stage=${this.stage}" | sudo tee "/etc/gatehouse/stage.conf" > /dev/null`, | |||
| executionStatement: `dpkg -i /${ec2App}/${ec2App}.deb`, | |||
There was a problem hiding this comment.
Because we're getting the stage from EC2 tags, we no longer need to write a file with the stage value in it.
pvighi
reviewed
Feb 6, 2024
| super.configuration | ||
| else | ||
| Configuration("play.http.secret.key" -> secretKey).withFallback(super.configuration) | ||
|
|
There was a problem hiding this comment.
are you planning to to use play secret rotation ? I think it's still the recommendation
There was a problem hiding this comment.
Yes I started looking at that. Thanks for the reminder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change to use the recommended simple configuration library to give us stage-specific config by reading the stage tag on the host EC2 instance.
I've largely followed the examples in the simple-configuration readme.
Tested on Code.