Upgrade to Panda v7 - support key rotation #1747
Conversation
|
I've resolved two compiler warnings in a way which might change some behaviour that I'm unfamiliar with @jonathonherbert - can you review 4a41ba5 ? |
| case Some(CardType.Chef) => | ||
| EditionsChef( | ||
| supportingCard.id, | ||
| supportingCard.frontPublicationDate, | ||
| supportingCard.meta.map(_.toChefMetadata) | ||
| ) | ||
| case _ => |
There was a problem hiding this comment.
Hi @davidfurey, thanks for asking,
If I remember, we do need case matching for Recipe and Chef only, we don't want this to work for Feast-Collection(FC), because we don't have yet supporting feature of FC (present inside another FC) to drag into some another FC.
Can we have undefined or something similar if we really need to do case _?
There was a problem hiding this comment.
I've discussed with Divya and decided to remove this change. Divya might look at resolving this warning in a later PR
There was a problem hiding this comment.
Thanks for discussion @davidfurey to discuss on ways to solve this.
I will make change in later PR and attach here as reference.
994dc0c to
9f69e01
Compare
|
Tested on CODE - auth with an existing panda cookie works, and logging in from incognito window also works |
This is fine, nothing but recipes should be in FeastCollection meta, and |
This upgrades Panda from v4 to v7, allowing us to use key rotation as introduced with guardian/pan-domain-authentication#150.
Implicit definition should have explicit type
Also removing unused endpoints
A pure expression does nothing in statement position
9f69e01 to
a904a9a
Compare
|
Seen on PROD (merged by @davidfurey 6 minutes and 23 seconds ago) Please check your changes! |
This upgrades Panda from v4 to v7, allowing us to use key rotation.
Follows the guidance from guardian/pan-domain-authentication#160 and based on guardian/atom-workshop#361
Testing