This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Store dates as strings #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To stop potentialy useage of date object and consistency
RichieAHB
commented
Jan 4, 2018
| startDate, | ||
| endDate | ||
| }); | ||
| import moment from 'moment'; |
There was a problem hiding this comment.
The changes in chartActions and chartsReducer is moving business logic from one place to the other. Mainly to make sure that moment dates don't make it into the reducer and potentially get stored. Also, while it doesn't especially matter in the app at present, it's best practice for async reasons: reduxjs/redux#1171
susiecoleman
approved these changes
Jan 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None string dates where causing problems where we were comparing filters for deep equality, which would require traversing the whole of a
momentobject. And when using===equal dates would returnfalse.