Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the dependencies group across 1 directory with 6 updates #1915

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Bump the dependencies group across 1 directory with 6 updates #1915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddc8da8
Bump the dependencies group across 1 directory with 6 updates
dependabot[bot] Feb 3, 2025
5de61bb
Update eslint peer dep
andrewHEguardian Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/hip-hornets-camp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@guardian/source-development-kitchen': patch
'@guardian/source': patch
---

Fix eslint errors after version bump
5 changes: 5 additions & 0 deletions .changeset/six-crabs-hang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@guardian/eslint-config': major
---

Updates eslint to v9.19.0
2 changes: 1 addition & 1 deletion libs/@guardian/ab-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"devDependencies": {
"@guardian/eslint-config": "workspace:*",
"@types/jest": "29.5.8",
"eslint": "9.14.0",
"eslint": "9.19.0",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
"rollup": "4.32.1",
Expand Down
2 changes: 1 addition & 1 deletion libs/@guardian/ab-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@types/jest": "29.5.8",
"@types/react": "18.2.79",
"@types/react-dom": "18.2.25",
"eslint": "9.14.0",
"eslint": "9.19.0",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
"react": "18.2.0",
Expand Down
2 changes: 1 addition & 1 deletion libs/@guardian/browserslist-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@guardian/browserslist-config": "workspace:*",
"@guardian/eslint-config": "workspace:*",
"browserslist": "4.23.0",
"eslint": "9.14.0",
"eslint": "9.19.0",
"tslib": "2.6.2",
"wireit": "0.14.8"
},
Expand Down
2 changes: 1 addition & 1 deletion libs/@guardian/core-web-vitals/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@guardian/eslint-config": "workspace:*",
"@guardian/libs": "20.0.0",
"@types/jest": "29.5.8",
"eslint": "9.14.0",
"eslint": "9.19.0",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
"rollup": "4.32.1",
Expand Down
16 changes: 8 additions & 8 deletions libs/@guardian/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,25 @@
},
"dependencies": {
"@eslint-community/eslint-plugin-eslint-comments": "4.4.1",
"@eslint/js": "9.16.0",
"@eslint/js": "9.19.0",
"@stylistic/eslint-plugin": "2.11.0",
"eslint-config-prettier": "9.1.0",
"eslint-import-resolver-typescript": "3.6.3",
"eslint-plugin-import-x": "4.4.3",
"eslint-import-resolver-typescript": "3.7.0",
"eslint-plugin-import-x": "4.6.1",
"eslint-plugin-jsx-a11y": "6.10.2",
"eslint-plugin-react": "7.37.2",
"eslint-plugin-react-hooks": "5.0.0",
"eslint-plugin-react-hooks": "5.1.0",
"eslint-plugin-storybook": "0.11.1",
"globals": "15.13.0",
"globals": "15.14.0",
"read-package-up": "11.0.0",
"typescript-eslint": "8.16.0"
"typescript-eslint": "8.22.0"
},
"devDependencies": {
"eslint": "9.14.0",
"eslint": "9.19.0",
"wireit": "0.14.8"
},
"peerDependencies": {
"eslint": "^9.14.0"
"eslint": "^9.19.0"
},
"wireit": {
"lint": {
Expand Down
2 changes: 1 addition & 1 deletion libs/@guardian/identity-auth-frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@guardian/identity-auth": "5.0.0",
"@guardian/libs": "20.0.0",
"@types/jest": "29.5.8",
"eslint": "9.14.0",
"eslint": "9.19.0",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
"jest-fetch-mock": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion libs/@guardian/identity-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@guardian/eslint-config": "workspace:*",
"@guardian/libs": "20.0.0",
"@types/jest": "29.5.8",
"eslint": "9.14.0",
"eslint": "9.19.0",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
"jest-fetch-mock": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion libs/@guardian/libs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@playwright/test": "1.48.0",
"@types/jest": "29.5.8",
"@types/wcag-contrast": "3.0.3",
"eslint": "9.14.0",
"eslint": "9.19.0",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
"jest-fetch-mock": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion libs/@guardian/newsletter-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"devDependencies": {
"@guardian/eslint-config": "workspace:*",
"eslint": "9.14.0",
"eslint": "9.19.0",
"rollup": "4.32.1",
"tslib": "2.6.2",
"typescript": "5.5.2",
Expand Down
2 changes: 1 addition & 1 deletion libs/@guardian/prettier/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"devDependencies": {
"@guardian/eslint-config": "workspace:*",
"eslint": "9.14.0",
"eslint": "9.19.0",
"prettier": "3.2.2",
"tslib": "2.6.2",
"wireit": "0.14.8"
Expand Down
3 changes: 2 additions & 1 deletion libs/@guardian/react-crossword/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,12 @@
"@types/jest": "29.5.8",
"@types/react": "18.2.79",
"dotenv": "16.4.1",
"eslint": "9.14.0",
"eslint": "9.19.0",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
"prettier": "3.3.3",
"react": "18.2.0",
"react-dom": "18.2.0",
"rollup": "4.32.1",
"storybook": "8.5.1",
"ts-jest": "29.2.3",
Expand Down
3 changes: 2 additions & 1 deletion libs/@guardian/source-development-kitchen/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@
"@storybook/react-vite": "8.5.1",
"@types/jest": "29.5.8",
"@types/react": "18.2.79",
"eslint": "9.14.0",
"eslint": "9.19.0",
"jest": "29.7.0",
"react": "18.2.0",
"react-dom": "18.2.0",
"rollup": "4.32.1",
"storybook": "8.5.1",
"ts-jest": "29.2.3",
Expand Down
11 changes: 6 additions & 5 deletions libs/@guardian/source-development-kitchen/src/react-components/file-input/fileHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@ export const stringifyFileBase64 = (file: File): Promise<string> =>
reader.addEventListener(
'load',
() => {
// remove data:*/*;base64, from the start of the base64 string
const fileAsBase64 = reader.result?.toString().split(';base64,')[1];

if (fileAsBase64) {
resolve(fileAsBase64);
if (typeof reader.result === 'string') {
// remove data:*/*;base64, from the start of the base64 string
const fileAsBase64 = reader.result.split(';base64,')[1];
if (fileAsBase64) {
resolve(fileAsBase64);
}
} else {
reject(
new Error('Sorry there was a problem with the file you uploaded.'),
Expand Down
3 changes: 2 additions & 1 deletion libs/@guardian/source/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,13 @@
"@types/jest": "29.5.8",
"@types/react": "18.2.79",
"dotenv": "16.4.1",
"eslint": "9.14.0",
"eslint": "9.19.0",
"jest": "29.7.0",
"lightningcss": "1.28.1",
"mkdirp": "3.0.1",
"prettier": "3.3.3",
"react": "18.2.0",
"react-dom": "18.2.0",
"rollup": "4.32.1",
"storybook": "8.5.1",
"ts-jest": "29.2.3",
Expand Down
2 changes: 1 addition & 1 deletion libs/@guardian/source/src/react-components/choice-card/ChoiceCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export const ChoiceCard = ({
htmlFor={id}
>
<div css={[contentWrapper, !iconSvg ? contentWrapperLabelOnly : '']}>
{iconSvg ? iconSvg : ''}
{iconSvg ?? ''}
<div>{labelContent}</div>
</div>
<span
Expand Down
Loading