Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Criteo in Australia and New Zealand #1649

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

emma-imber
Copy link
Contributor

What does this change?

Re-enables Criteo for Australia and New Zealand as requested, and updates the bid-config tests accordingly.

I tested locally using a VPN and requests are being sent as expected:

Screenshot 2024-11-07 at 15 38 27

@emma-imber emma-imber requested a review from a team as a code owner November 7, 2024 15:45
Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: 598cb02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Ad load time test results

For consented, top-above-nav took on average 5126ms to load.
For consentless, top-above-nav took on average 3295ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@emma-imber emma-imber merged commit 1efa8ca into main Nov 7, 2024
13 checks passed
@emma-imber emma-imber deleted the ei/enable-criteo-aus-nz branch November 7, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants