Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node from 14 -> 18 #412

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Upgrade Node from 14 -> 18 #412

merged 2 commits into from
Apr 24, 2023

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Apr 21, 2023

What does this change?

Upgrades the version of Node used by the project from 14 to 18 (14 is EOL very soon).

I also had to upgrade the version of webpack used by Storybook because I was seeing errors after upgrading to Node 18 relating to digital envelope routines. Specifically the error code was ERR_OSSL_EVP_UNSUPPORTED. Upgrading the version of webpack used by storybook fixes things.

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

tjmw added 2 commits April 21, 2023 16:19
This fixes an error I was seeing after upgrading to Node 18 relating to
digital envelope routines. Specifically the error code was
ERR_OSSL_EVP_UNSUPPORTED.

This comment on a related GH thread was useful:
storybookjs/storybook#19692 (comment)
@tjmw tjmw marked this pull request as ready for review April 21, 2023 16:15
Copy link
Member

@tomrf1 tomrf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great!

@tjmw tjmw merged commit 00155d1 into main Apr 24, 2023
@tjmw tjmw deleted the tw/node-18 branch April 24, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants