Merge pull request #15 from guardian/kc-upstream

Merge from upstream

.github/stale.yml

@@ -0,0 +1,18 @@
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 14
+# Number of days of inactivity before a stale issue is closed
+daysUntilClose: 7
+# Issues with these labels will never be considered stale
+exemptLabels:
+  - pinned
+  - security
+  - bug
+# Label to use when marking an issue as stale
+staleLabel: wontfix
+# Comment to post when marking an issue as stale. Set to `false` to disable
+markComment: >
+  This issue has been automatically marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs. Thank you
+  for your contributions.
+# Comment to post when closing a stale issue. Set to `false` to disable
+closeComment: false

PR_REVIEW.md

@@ -33,6 +33,7 @@ For modules and core platform updates, the initial reviewer should request an ad
 - All user-sync (aka pixel) activity must be registered via the provided functions
 - Adapters may not use the $$PREBID_GLOBAL$$ variable
 - All adapters must support the creation of multiple concurrent instances. This means, for example, that adapters cannot rely on mutable global variables.
+- Adapters may not globally override or default the standard ad server targeting values: hb_adid, hb_bidder, hb_pb, hb_deal, or hb_size, hb_source, hb_format.
 
 ## Ticket Coordinator
 

modules/33acrossBidAdapter.js

@@ -4,7 +4,7 @@ const { config } = require('../src/config');
 
 const BIDDER_CODE = '33across';
 const END_POINT = 'https://ssc.33across.com/api/v1/hb';
-const SYNC_ENDPOINT = 'https://de.tynt.com/deb/v2?m=xch';
+const SYNC_ENDPOINT = 'https://de.tynt.com/deb/v2?m=xch&rt=html';
 
 // All this assumes that only one bid is ever returned by ttx
 function _createBidResponse(response) {

modules/adformBidAdapter.js

@@ -1,10 +1,12 @@
 'use strict';
 
 import {registerBidder} from 'src/adapters/bidderFactory';
+import { BANNER, VIDEO } from 'src/mediaTypes';
 
 const BIDDER_CODE = 'adform';
 export const spec = {
   code: BIDDER_CODE,
+  supportedMediaTypes: [ BANNER, VIDEO ],
   isBidRequestValid: function (bid) {
     return !!(bid.params.mid);
   },
@@ -64,14 +66,20 @@ export const spec = {
     }
   },
   interpretResponse: function (serverResponse, bidRequest) {
-    var bidObject, response, bid;
+    const VALID_RESPONSES = {
+      banner: 1,
+      vast_content: 1,
+      vast_url: 1
+    };
+    var bidObject, response, bid, type;
     var bidRespones = [];
     var bids = bidRequest.bids;
     var responses = serverResponse.body;
     for (var i = 0; i < responses.length; i++) {
       response = responses[i];
+      type = response.response === 'banner' ? BANNER : VIDEO;
       bid = bids[i];
-      if (response.response === 'banner' && verifySize(response, bid.sizes)) {
+      if (VALID_RESPONSES[response.response] && (verifySize(response, bid.sizes) || type === VIDEO)) {
         bidObject = {
           requestId: bid.bidId,
           cpm: response.win_bid,
@@ -84,7 +92,10 @@ export const spec = {
           ttl: 360,
           ad: response.banner,
           bidderCode: bidRequest.bidder,
-          transactionId: bid.transactionId
+          transactionId: bid.transactionId,
+          vastUrl: response.vast_url,
+          vastXml: response.vast_content,
+          mediaType: type
         };
         bidRespones.push(bidObject);
       }

modules/adformBidAdapter.md

@@ -7,7 +7,7 @@ Maintainer: Scope.FL.Scripts@adform.com
 # Description
 
 Module that connects to Adform demand sources to fetch bids.
-Banner formats are supported.
+Banner and video formats are supported.
 
 # Test Parameters
 ```

modules/adyoulikeBidAdapter.js

@@ -2,6 +2,7 @@ import * as utils from 'src/utils';
 import { format } from 'src/url';
 // import { config } from 'src/config';
 import { registerBidder } from 'src/adapters/bidderFactory';
+import find from 'core-js/library/fn/array/find';
 
 const VERSION = '1.0';
 const BIDDER_CODE = 'adyoulike';
@@ -77,7 +78,7 @@ export const spec = {
 
 /* Get hostname from bids */
 function getHostname(bidderRequest) {
-  let dcHostname = bidderRequest.find(bid => bid.params.DC);
+  let dcHostname = find(bidderRequest, bid => bid.params.DC);
   if (dcHostname) {
     return ('-' + dcHostname.params.DC);
   }

modules/audienceNetworkBidAdapter.js

@@ -26,7 +26,8 @@ const isBidRequestValid = bid =>
   typeof bid.params.placementId === 'string' &&
   bid.params.placementId.length > 0 &&
   Array.isArray(bid.sizes) && bid.sizes.length > 0 &&
-  (isVideo(bid.params.format) || bid.sizes.map(flattenSize).some(isValidSize));
+  (isFullWidth(bid.params.format) ? bid.sizes.map(flattenSize).every(size => size === '300x250') : true) &&
+  (isValidNonSizedFormat(bid.params.format) || bid.sizes.map(flattenSize).some(isValidSize));
 
 /**
  * Flattens a 2-element [W, H] array as a 'WxH' string,
@@ -51,13 +52,37 @@ const expandSize = size => size.split('x').map(Number);
  */
 const isValidSize = size => includes(['300x250', '320x50'], size);
 
+/**
+ * Is this a valid, non-sized format?
+ * @param {String} size
+ * @returns {Boolean}
+ */
+const isValidNonSizedFormat = format => includes(['video', 'native'], format);
+
+/**
+ * Is this a valid size and format?
+ * @param {String} size
+ * @returns {Boolean}
+ */
+const isValidSizeAndFormat = (size, format) =>
+  (isFullWidth(format) && flattenSize(size) === '300x250') ||
+  isValidNonSizedFormat(format) ||
+  isValidSize(flattenSize(size));
+
 /**
  * Is this a video format?
  * @param {String} format
  * @returns {Boolean}
  */
 const isVideo = format => format === 'video';
 
+/**
+ * Is this a fullwidth format?
+ * @param {String} format
+ * @returns {Boolean}
+ */
+const isFullWidth = format => format === 'fullwidth';
+
 /**
  * Which SDK version should be used for this format?
  * @param {String} format
@@ -120,7 +145,7 @@ const buildRequests = bids => {
 
   bids.forEach(bid => bid.sizes
     .map(flattenSize)
-    .filter(size => isValidSize(size) || isVideo(bid.params.format))
+    .filter(size => isValidSizeAndFormat(size, bid.params.format))
     .slice(0, 1)
     .forEach(size => {
       placementids.push(bid.params.placementId);