-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/registry collector cli additions #2241
Feat/registry collector cli additions #2241
Conversation
7f7e751
to
e04d37b
Compare
e04d37b
to
bcca5fe
Compare
19e13f7
to
27a4bbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor changes requested, else LGTM!
dcacfb5
to
7720cd0
Compare
7720cd0
to
8da9f23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the changes! Rebasing on main should fix the CI flakes
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
8da9f23
to
9aae87d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of the PR
Fixes #298
FYI: this branch is rebased onto #2185 so that will need to be merged before this one. I think this is the correct order cc @lumjjb
This PR only targets the second commit: 7f7e751
PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run