Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/registry collector cli additions #2241

Merged

Conversation

robert-cronin
Copy link
Collaborator

@robert-cronin robert-cronin commented Oct 29, 2024

Description of the PR

Fixes #298
FYI: this branch is rebased onto #2185 so that will need to be merged before this one. I think this is the correct order cc @lumjjb

This PR only targets the second commit: 7f7e751

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@robert-cronin robert-cronin mentioned this pull request Oct 29, 2024
9 tasks
@robert-cronin robert-cronin force-pushed the feat/registry-collector-cli-additions branch from 7f7e751 to e04d37b Compare October 29, 2024 23:01
@pxp928 pxp928 requested a review from lumjjb November 4, 2024 14:42
@robert-cronin robert-cronin force-pushed the feat/registry-collector-cli-additions branch from e04d37b to bcca5fe Compare November 4, 2024 22:47
@robert-cronin robert-cronin force-pushed the feat/registry-collector-cli-additions branch 2 times, most recently from 19e13f7 to 27a4bbf Compare November 5, 2024 22:52
@pxp928 pxp928 added the needs-review Needs writer LGTM label Nov 8, 2024
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor changes requested, else LGTM!

@robert-cronin robert-cronin force-pushed the feat/registry-collector-cli-additions branch 2 times, most recently from dcacfb5 to 7720cd0 Compare November 11, 2024 04:07
@robert-cronin robert-cronin requested a review from lumjjb November 11, 2024 05:17
@robert-cronin robert-cronin force-pushed the feat/registry-collector-cli-additions branch from 7720cd0 to 8da9f23 Compare November 14, 2024 23:19
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes! Rebasing on main should fix the CI flakes

Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
@robert-cronin robert-cronin force-pushed the feat/registry-collector-cli-additions branch from 8da9f23 to 9aae87d Compare November 17, 2024 22:05
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 6ee6b6e into guacsec:main Nov 20, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Needs writer LGTM size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry collector to expand OCI collector
3 participants