Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment on certifier when last-scan is set or not set #2167

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Oct 4, 2024

Description of the PR

add comment on certifier when last-scan is set or not set

{"level":"info","ts":1728063401.121687,"caller":"certify/certify.go:109","msg":"Starting certifier run: 2024-10-04 17:36:41.121594 +0000 UTC","guac-version":"v0.0.1-custom"}
{"level":"info","ts":1728063401.1218429,"caller":"root_package/root_package.go:74","msg":"last-scan set to: 4, last scan time set to: 2024-10-04 13:36:41.121823 +0000 UTC","guac-version":"v0.0.1-custom"}
{"level":"info","ts":1728063401.241639,"caller":"certify/certify.go:114","msg":"Certifier run completed: 2024-10-04 17:36:41.241626 +0000 UTC","guac-version":"v0.0.1-custom"}

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
Copy link
Contributor

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a good addition for sysadmins :-)

@kodiakhq kodiakhq bot merged commit 6d47f0c into main Oct 4, 2024
9 of 10 checks passed
@kodiakhq kodiakhq bot deleted the last-scan-comment branch October 4, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants