Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include e2e tests for guaccollect, guacingest, and ent #1998

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Include e2e tests for guaccollect, guacingest, and ent #1998

merged 7 commits into from
Jul 9, 2024

Conversation

nathannaveen
Copy link
Collaborator

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen nathannaveen marked this pull request as draft July 2, 2024 16:02
@nathannaveen nathannaveen force-pushed the nathan/newE2eWithCherry branch from fe5a3fd to 74b16d7 Compare July 2, 2024 16:26
@nathannaveen nathannaveen force-pushed the nathan/newE2eWithCherry branch 5 times, most recently from 41a3e4b to 812b76b Compare July 2, 2024 17:43
pxp928
pxp928 reviewed Jul 2, 2024
View reviewed changes
pxp928
pxp928 reviewed Jul 2, 2024
View reviewed changes
@nathannaveen nathannaveen force-pushed the nathan/newE2eWithCherry branch 10 times, most recently from 6cb858f to fd5b5cd Compare July 2, 2024 18:45
@pxp928
Copy link
Collaborator

pxp928 commented Jul 4, 2024

@nathannaveen this can be rebased now!

nathannaveen and others added 6 commits July 4, 2024 16:09
@nathannaveen
Included e2e tests for guaccollect, guacingest and ent
3974b04 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Fixing e2e
caebf17 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: Nathan Naveen <nathannaveen@Nathans-MacBook-Pro.local>
Most Passing, but Deadlock Failing
318ce83 
Signed-off-by: Nathan Naveen <nathannaveen@Nathans-MacBook-Pro.local>
Mostly Passing
6c5069a 
Signed-off-by: Nathan Naveen <nathannaveen@Nathans-MacBook-Pro.local>
@nathannaveen
Cleaning up
7cdf096 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Working e2e
a6eb32e 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen nathannaveen force-pushed the nathan/newE2eWithCherry branch from fd5b5cd to a6eb32e Compare July 4, 2024 21:11
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Jul 4, 2024
@nathannaveen
Copy link
Collaborator Author

Thanks @pxp928, rebased

@pxp928
Copy link
Collaborator

pxp928 commented Jul 8, 2024

This is ready for review now right @nathannaveen ?

@pxp928 pxp928 added the needs-review Needs writer LGTM label Jul 8, 2024
Revert changes to docker-compose.yml to match main branch
3e71c00 
Signed-off-by: nathan naveen <nathannaveen@nathans-MacBook-Pro-2.local>
@nathannaveen nathannaveen force-pushed the nathan/newE2eWithCherry branch from b26a452 to 3e71c00 Compare July 8, 2024 15:46
@nathannaveen nathannaveen marked this pull request as ready for review July 8, 2024 15:58
@nathannaveen
Copy link
Collaborator Author

I cleaned up the code a bit, now it should be ready to review.

pxp928
pxp928 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! small nit

@pxp928
Copy link
Collaborator

pxp928 commented Jul 9, 2024

Great improvement to the e2e test!

@pxp928 pxp928 requested review from lumjjb and jeffmendoza July 9, 2024 13:39
mihaimaruseac
mihaimaruseac approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Thank you!

@kodiakhq kodiakhq bot merged commit 53a63ab into guacsec:main Jul 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funnelfiasco funnelfiasco funnelfiasco left review comments

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza

Assignees
No one assigned
Labels
needs-review Needs writer LGTM size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Update E2E tests (or create new ones) to test guaccollect and the other components
4 participants
@nathannaveen @pxp928 @mihaimaruseac @funnelfiasco