Update ent and arango source model generation. #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source name can have Tag or Commit but not both. The model marks these as optional which results in go structs with pointers. The backends should only fill the pointers if the field is valid. Signed-off-by: Jeff Mendoza <jlm@jlm.name>
mihaimaruseac
approved these changes
Dec 19, 2023
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
Signed-off-by: Jeff Mendoza <jlm@jlm.name>
pxp928
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source name can have Tag or Commit but not both. The model marks these as optional which results in go structs with pointers. The backends should only fill the pointers if the field is valid.
The generated go structs do have "omitempty" in the json annotation, so I believe the gql results still look correct without this change. This does clean up the expected test data. All the backends will need to be consistent to have the same expected testdata.
PR Checklist
-sflag togit commit.make generatehas been runcollectsubprotobuf has been changed,make protohas been run