Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Collector Enhancements #1566

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Github Collector Enhancements #1566

merged 9 commits into from
Jan 29, 2024

Conversation

nathannaveen
Copy link
Collaborator

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen nathannaveen force-pushed the nathan/githubCollectorEnhancements branch from 715b5be to 1e8f2b3 Compare December 9, 2023 01:34
jeffmendoza
jeffmendoza reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@jeffmendoza jeffmendoza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, mostly naming.
Functionally, the main issue is the looping in GetWorkflowRunArtifacts, we only want to be getting the artifacts from the latest run(s)

@nathannaveen nathannaveen force-pushed the nathan/githubCollectorEnhancements branch 2 times, most recently from 35fa882 to 55c9a63 Compare December 14, 2023 21:01
@nathannaveen nathannaveen force-pushed the nathan/githubCollectorEnhancements branch from 19bf7f4 to 78851f3 Compare December 19, 2023 20:22
jeffmendoza
jeffmendoza reviewed Dec 22, 2023
View reviewed changes
Copy link
Member

@jeffmendoza jeffmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A couple nits. The json filter question is the only concern.

@nathannaveen nathannaveen force-pushed the nathan/githubCollectorEnhancements branch from b99855b to fed11cc Compare January 9, 2024 16:37
pxp928
pxp928 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just need a rebase!

@nathannaveen nathannaveen force-pushed the nathan/githubCollectorEnhancements branch from c30c5e4 to 36307d8 Compare January 29, 2024 17:31
@nathannaveen
Initial Commit
702a147 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Included More features
07e9461 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Included Service Poll
95b16e0 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Finishing Touches
9e935c3 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Fixed Lint
e4a098a 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Updated Based on Code Review
d25dfc0 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Fixed Artifact Download
320c38e 
* The Github API returns a zip file with the artifacts, I thought that it was actualy a JSON, so I am now fixing it

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Fixed tests
30f0881 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen
Updated Based on Code Review
e4c6f6f 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen nathannaveen force-pushed the nathan/githubCollectorEnhancements branch from 36307d8 to e4c6f6f Compare January 29, 2024 17:32
@kodiakhq kodiakhq bot merged commit 52a55e4 into guacsec:main Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Github collector enhancements
3 participants
@nathannaveen @jeffmendoza @pxp928