Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xml support to cyclonedx handlers #150

Merged
merged 9 commits into from
Feb 13, 2023
Merged

Conversation

cpendery
Copy link
Collaborator

@cpendery cpendery commented Oct 13, 2022

📝 Description

Adds xml support for the CycloneDX guesser, processor, and ingestor.

Closes #102

@cpendery cpendery marked this pull request as ready for review October 22, 2022 01:50
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, else lgtm!

@lumjjb
Copy link
Contributor

lumjjb commented Jan 4, 2023

hi @cpendery sorry for the late review on this - do you mind rebasing please! Thanks so much!

@lumjjb
Copy link
Contributor

lumjjb commented Jan 20, 2023

Hi @cpendery ! hope all is going well! Just checking in!

@lumjjb
Copy link
Contributor

lumjjb commented Jan 28, 2023

👋 @cpendery

Signed-off-by: cpendery <cpendery@vt.edu>
Signed-off-by: cpendery <cpendery@vt.edu>
Signed-off-by: cpendery <cpendery@vt.edu>
Signed-off-by: cpendery <cpendery@vt.edu>
Signed-off-by: cpendery <cpendery@vt.edu>
Signed-off-by: cpendery <cpendery@vt.edu>
Signed-off-by: cpendery <cpendery@vt.edu>
Signed-off-by: cpendery <cpendery@vt.edu>
…yclonedx xml

Signed-off-by: cpendery <cpendery@vt.edu>
@cpendery
Copy link
Collaborator Author

@lumjjb Let me know if the changes don't work. Sorry again about the delay

Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @cpendery

@kodiakhq kodiakhq bot merged commit 93c69dd into guacsec:main Feb 13, 2023
mrizzi added a commit to mrizzi/guac that referenced this pull request Oct 30, 2024
Signed-off-by: mrizzi <mrizzi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task: [processor/ingestor] CycloneDX support
3 participants