Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultPropsを使わないようにする #25

Closed
gsuke opened this issue Sep 17, 2022 · 0 comments · Fixed by #26
Closed

defaultPropsを使わないようにする #25

gsuke opened this issue Sep 17, 2022 · 0 comments · Fixed by #26

Comments

@gsuke
Copy link
Owner

gsuke commented Sep 17, 2022 •
edited
Loading

現在のESLintのルールでは、propsのデフォルト値を設定するときにdefaultPropsを使うようになっている。
しかし、関数コンポーネント + TypeScriptで書いている場合は、これを使うのは不適切に思える。

参考文献
@gsuke gsuke mentioned this issue Sep 17, 2022
Merged
@gsuke gsuke closed this as completed in #26 Sep 17, 2022
gsuke added a commit that referenced this issue Sep 17, 2022
@gsuke
Merge pull request #26 from gsuke/feature/#25-remove-defaultprops
fea76e7 
refactor: remove "defaultProps"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove "defaultProps" gsuke/engineer-sns-client
1 participant
@gsuke