Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to aws-sdk-go-v2? #1432

Closed
artem-nefedov opened this issue Aug 8, 2024 · 4 comments · Fixed by #1451
Closed

Migration to aws-sdk-go-v2? #1432

artem-nefedov opened this issue Aug 8, 2024 · 4 comments · Fixed by #1451
Labels
enhancement New feature or request terratest

Comments

@artem-nefedov
Copy link

AWS SDK for Go (v1) is already in maintenance mode since July 31, 2024, and is moving towards end of life:
https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/

Are there any plans to migrate Terratest to aws-sdk-go-v2?

@wakeful
Copy link
Contributor

wakeful commented Oct 6, 2024

hey @artem-nefedov

Can you help test my PR #1451?
You can point to my fork by using the replace directive in your go.mod file.

go mod init github.com/wakeful/new-project
go mod edit -replace github.com/gruntwork-io/terratest@v0.47.2=github.com/wakeful/terratest@v0.48.0
go get github.com/gruntwork-io/terratest/modules/aws@v0.47.2

wakeful added a commit to wakeful/terratest that referenced this issue Oct 15, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Oct 15, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Nov 2, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Nov 8, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Nov 15, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Nov 16, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Nov 19, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Nov 19, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Nov 20, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Nov 20, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Nov 25, 2024
wakeful added a commit to wakeful/terratest that referenced this issue Nov 26, 2024
@odgrim odgrim reopened this Dec 2, 2024
@odgrim odgrim closed this as completed Dec 2, 2024
@odgrim odgrim reopened this Dec 2, 2024
@artem-nefedov
Copy link
Author

Seems done to me

@uchanchlani
Copy link

uchanchlani commented Dec 17, 2024

The changes introduced in PR #1451 modify the signatures of exposed functions, which is a breaking change. As a result, this should have triggered a major version bump from 0.47.2 to 1.0.0, rather than a minor version bump to 0.48.0.

For example, the function NewEcsClientE in modules/aws/ecs.go previously returned *(github.com/aws/aws-sdk-go/service/)ecs.ECS. After this PR, it now returns *(github.com/aws/aws-sdk-go-v2/service/)ecs.Client. This breaking change impacts compatibility and aligns with semantic versioning principles, which mandate a major version increment for such updates.

@ZachGoldberg
Copy link
Contributor

Hi @uchanchlani ! Thanks for the thoughtful feedback!

Terratest is still pre-1.0, and as such does not have backwards compatibility guarantees within its major version of 0. We tend to use minor version bumps to indicate when things might break. Gruntwork is, however, pushing to get all of the tools it maintains to 1.0 and begin enforcing such a backwards compatibility promise, although we are not there yet. I/we apologize if this causes any inconvenience along the way, however we feel its important that we have a stable foundation that we can commit to for a long time before officially releasing 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request terratest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants