Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Add vertical pod autoscaling option #84

Merged
merged 3 commits into from
Mar 25, 2020
Merged

Add vertical pod autoscaling option #84

merged 3 commits into from
Mar 25, 2020

Conversation

jsirianni
Copy link
Contributor

  • added option to enable vertical pod autoscaling
  • set vertical pod autoscaling to true for public and private test clusters
  • tested with go test -v -timeout 60m -run TestGKECluster

This is a backwards compatible change. Clusters deployed with v0.4.0 of this module have vertical autoscaling disabled, which is the default behavior for this change.

The first run with this module will give the following terraform plan for clusters deployed with v0.4.0 of this module:

      + vertical_pod_autoscaling {
          + enabled = false
        }

Despite autoscaling already being disabled, Terraform wants to apply the change anyway. The change is applied in place quickly without actually changing anything. This is only for the initial run after upgrading the module.

resolves #83

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This LGTM. Will kick off our build shortly.

@jsirianni
Copy link
Contributor Author

Looks like the build system failed, but I am not sure it is related to this change. Let me know if I need to do anything on my end, thanks 👍

@yorinasub17
Copy link
Contributor

Gah yes you are right that it isn't related to this change. I just fixed it on master. When you get the chance, can you rebase on to master to pull the fix in? Thanks!

merge ci changes from upstream
@jsirianni
Copy link
Contributor Author

@yorinasub17 done 👍

@yorinasub17
Copy link
Contributor

Ok build passed, so will merge this in. Thanks for your contribution!

@yorinasub17 yorinasub17 merged commit 41c827b into gruntwork-io:master Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Vertical Pod Autoscaling
2 participants