Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for cloud-nuke-excluded tag in VPC resource, fix #810 #811

Merged
merged 1 commit into from
Dec 17, 2024
Merged

add support for cloud-nuke-excluded tag in VPC resource, fix #810 #811

merged 1 commit into from
Dec 17, 2024

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Dec 16, 2024

Description

Fixes #810 add support cloud-nuke-excluded tag.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added support cloud-nuke-excluded tag - Fixes #810

Migration Guide

n/a

@wakeful wakeful mentioned this pull request Dec 16, 2024
Closed
@wakeful wakeful force-pushed the fix-810-add-support-to-skip-vpc-by-tag branch from 5e2f40a to 6a1d196 Compare December 16, 2024 16:27
james03160927
james03160927 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit ffd2e75 into gruntwork-io:master Dec 17, 2024
2 checks passed
@wakeful wakeful deleted the fix-810-add-support-to-skip-vpc-by-tag branch December 17, 2024 06:57
@ErezWeiss
Copy link

ErezWeiss commented Dec 17, 2024 •
edited
Loading

Hi guys
When will it be published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james03160927 james03160927 james03160927 approved these changes

@arsci arsci Awaiting requested review from arsci arsci is a code owner

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I can't exclude VPC with cloud-nuke-excluded tag or any other
3 participants
@wakeful @ErezWeiss @james03160927