Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register missing resource - TGW Peering Attachment #802

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Dec 4, 2024

Description

I was running dead code analysis and noticed that the TransitGatewayPeeringAttachment resource is not being used.

aws/resources/tgw_peering_attachment.go:14:46: unreachable func: TransitGatewayPeeringAttachment.getAll
aws/resources/tgw_peering_attachment.go:34:46: unreachable func: TransitGatewayPeeringAttachment.nukeAll
aws/resources/tgw_peering_attachment_types.go:22:46: unreachable func: TransitGatewayPeeringAttachment.Init
aws/resources/tgw_peering_attachment_types.go:26:46: unreachable func: TransitGatewayPeeringAttachment.ResourceName
aws/resources/tgw_peering_attachment_types.go:30:46: unreachable func: TransitGatewayPeeringAttachment.MaxBatchSize
aws/resources/tgw_peering_attachment_types.go:34:46: unreachable func: TransitGatewayPeeringAttachment.ResourceIdentifiers
aws/resources/tgw_peering_attachment_types.go:38:46: unreachable func: TransitGatewayPeeringAttachment.GetAndSetResourceConfig
aws/resources/tgw_peering_attachment_types.go:42:46: unreachable func: TransitGatewayPeeringAttachment.GetAndSetIdentifiers
aws/resources/tgw_peering_attachment_types.go:52:46: unreachable func: TransitGatewayPeeringAttachment.Nuke

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added TransitGatewayPeeringAttachment to be loaded.

Migration Guide

n/a

@james03160927 james03160927 self-assigned this Dec 5, 2024
james03160927
james03160927 previously approved these changes Dec 5, 2024
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927
Copy link
Contributor

It seems like there are some merge conflict. We can submit it once it's resolved.

@wakeful wakeful force-pushed the register-tgw-peering-attachment-missing-resource branch from aabafe4 to 818ed81 Compare December 5, 2024 07:11
@wakeful
Copy link
Contributor Author

wakeful commented Dec 5, 2024

It seems like there are some merge conflict. We can submit it once it's resolved.

resolved

@wakeful
Copy link
Contributor Author

wakeful commented Dec 5, 2024

hey @james03160927

I added another commit to this MR with code changes to move the transit-gateway-peering-attachment resource to AWS SDK v2.

Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit 44ffa25 into gruntwork-io:master Dec 6, 2024
2 checks passed
@wakeful wakeful deleted the register-tgw-peering-attachment-missing-resource branch December 6, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants