Migrate S3 to SDK v2 #779

james03160927 · 2024-11-08T00:32:57Z

Description

Partially fixing #770

Update the docs.
Run the relevant tests successfully, including pre-commit checks.
Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
Include release notes. If this PR is backward incompatible, include a migration guide.
Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Added / Removed / Updated [X].

james03160927 · 2024-11-12T01:06:36Z

Rebased.

aws/resources/s3.go

util/tag.go

denis256 · 2024-11-20T20:05:22Z

Conflicting files
go.mod
go.sum

go.mod

james03160927 requested review from arsci and denis256 as code owners November 8, 2024 00:32

james03160927 force-pushed the migrate/s3 branch 4 times, most recently from 731a968 to c474c06 Compare November 12, 2024 01:06

denis256 reviewed Nov 12, 2024

View reviewed changes

aws/resources/s3.go Outdated Show resolved Hide resolved

util/tag.go Show resolved Hide resolved

Migrate/s3

190e942

james03160927 force-pushed the migrate/s3 branch from b0dd634 to e91bdf6 Compare November 21, 2024 01:11

wakeful reviewed Nov 21, 2024

View reviewed changes

go.mod Outdated Show resolved Hide resolved

migrate: aws v2 s3

ef3ff56

james03160927 force-pushed the migrate/s3 branch from e91bdf6 to ef3ff56 Compare November 22, 2024 03:38

denis256 approved these changes Nov 22, 2024

View reviewed changes

james03160927 merged commit c7caecb into master Nov 25, 2024
3 checks passed

james03160927 deleted the migrate/s3 branch November 25, 2024 02:18