Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IGW exclusion to not delete in phxdevops #662

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Conversation

arsci
Copy link
Contributor

@arsci arsci commented Mar 28, 2024

Description

  • Add name exclusion for IGW in phxdevops

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes

Added name exclusion for IGW in phxdevops

@arsci arsci requested a review from brikis98 March 28, 2024 16:33
Comment on lines 279 to 280
# Exclude the IGW for default VPCs in phxdevops
- "gw-new-default-igw"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a pain, but could you make even more context? This says what it does, but not why?

Something like, "We use the Default VPC in many of our tests, and without an IGW, ..."

@arsci arsci requested a review from brikis98 April 1, 2024 15:35
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍

@arsci arsci merged commit 2e34b83 into master Apr 1, 2024
3 checks passed
@arsci arsci deleted the fix/igw-default branch January 22, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants