support route53 services #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis256
reviewed
Mar 4, 2024
| "github.com/gruntwork-io/cloud-nuke/report" | ||
| ) | ||
|
|
||
| func (r Route53CidrCollection) getAll(c context.Context, configObj config.Config) ([]*string, error) { |
There was a problem hiding this comment.
I was wondering why is used value instead of pointer like in other cases like:
https://github.com/gruntwork-io/cloud-nuke/blob/master/aws/resources/ec2.go#L27
denis256
reviewed
Mar 4, 2024
| } | ||
|
|
||
| // nukeCidrLocations | ||
| func (r Route53CidrCollection) nukeCidrLocations(id *string) (err error) { |
There was a problem hiding this comment.
I suspect returning only error will be shorter and consistent with code for other resources (same thing for other functions which return (err error))
func (r Route53CidrCollection) nukeCidrLocations(id *string) error
| return ids, nil | ||
| } | ||
|
|
||
| // nukeCidrLocations |
There was a problem hiding this comment.
I think longer description will be helpful
There was a problem hiding this comment.
Makes sense. Let me address it. I think it makes sense to just remove it as well.
denis256
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #413
TODOs
Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide