Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Init Methods on All Resource Types + Refactor GetAll and ListAll methods #562

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

james03160927
Copy link
Contributor

Description

As part of #494.
There are several changes included in this PR:

  • Methods with a value receiver cannot modify the receiver object. They work with a copy of the receiver, so any changes made to the receiver within the method will not affect the original object. Therefore, I changed to a pointer receiver for each resource type method.
  • To refactor the initialization logic, implemented the initialization method in each resource types
  • Refactor GetAll & ListAll operations -- now we only need to include the new resource type in the registry file.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Updated [Implement Init Methods on All Resource Types + Refactor GetAll and ListAll methods]

Migration Guide

@james03160927 james03160927 merged commit f3c1ee0 into master Aug 15, 2023
@james03160927 james03160927 deleted the Init_Registry branch August 15, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants