Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Client & Region in each Resource Type + Config Resource type & name changes for consistency #508

Closed
wants to merge 2 commits into from

Conversation

james03160927
Copy link
Contributor

Description

Backward Incompatible Changes, including config name & resource type & resource names changes for consistency.

  • inconsistency in naming (e..g, sometime use plural, sometime use singular)

Part of #494.

TODO: make necessary changes in nuke_sandbox and nuke_phxdevops jobs.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • [] Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Updated [Introduce Client & Region in each Resource Type + Config Resource type & name changes for consistency]

Migration Guide

Looking at the README page, users would have to change the resource type & name mapping in their configuration file, If they were using the configuration file to run cloud-nuke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant