Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uglify to v2.7.0. #416

Merged
merged 4 commits into from
Jul 19, 2016
Merged

Update uglify to v2.7.0. #416

merged 4 commits into from
Jul 19, 2016

Conversation

XhmikosR
Copy link
Member

/CC @shama @vladikoff for thoughts and new version number suggestion.

@XhmikosR XhmikosR mentioned this pull request Jul 13, 2016
@XhmikosR XhmikosR force-pushed the update-uglify branch 2 times, most recently from f46edb2 to 802b401 Compare July 13, 2016 07:37
@avdg
Copy link
Contributor

avdg commented Jul 13, 2016

Uh not sure how to get these ie8 tests fixed. If they don't test the output for being ie8 friendly then they aren't needed. But those tests will be removed on long term anyway.

@XhmikosR
Copy link
Member Author

Huh???? They are tested just fine.

@avdg
Copy link
Contributor

avdg commented Jul 13, 2016

Uh.., I just saw theses tests being modified. I might have been too worried. I didn't had time to look deeper into it yet.

@avdg
Copy link
Contributor

avdg commented Jul 13, 2016

Ah yeah, the test is just doing the opposite after it and testing when screwIE8 is enabled instead of disabled. Edgy but fine I guess since these tests will be removed long term anyway...

@avdg avdg mentioned this pull request Jul 13, 2016
@XhmikosR XhmikosR force-pushed the update-uglify branch 3 times, most recently from 69e89c1 to 64482bf Compare July 19, 2016 07:20
@XhmikosR XhmikosR self-assigned this Jul 19, 2016
@vladikoff
Copy link
Member

AppVeyor says "good". let Travis check master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants