Skip to content

Commit

Permalink
fix typo
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexlamsl
alexlamsl committed May 20, 2017
1 parent 755360b commit 85a1ac3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tasks/lib/uglify.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ exports.init = function(grunt) {
output: options.output || {},
parse: options.parse || {},
sourceMap: options.sourceMap,
toplevel: options.topLevel,
toplevel: options.toplevel,
wrap: options.wrap
};

Expand Down

6 comments on commit 85a1ac3

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexlamsl: don't we need a new patch release for this?

@alexlamsl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XhmikosR indeed we would.

How is the release process done, or shall I just ping you about this in the future?

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented on 85a1ac3 May 20, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add a changelog entry
  • Bump version in package.json
  • Run grunt
  • push and create the tag (I do this manually on GH)
  • then git pull tags && npm publish

@alexlamsl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ npm publish
npm ERR! code E403

npm ERR! you do not have permission to publish "grunt-contrib-uglify". Are you logged in as the correct user? : grunt-contrib-uglify

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you don't have rights for this and I don't manage the npm account either. Only @vladikoff can give you npm rights.

I published 3.0.1. BTW you need to do git pull in the last step.

@alexlamsl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help 👍

I normally use git fetch --tags then git checkout [tagged_version] but your way is shorter.

@vladikoff may I have npm publish rights to this module?

Please sign in to comment.