Fix beautify when passed as an object.

gruntjs · Jul 13, 2016 · 5923f5b · 5923f5b
1 parent 5fc442f
commit 5923f5b
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 10 deletions.
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -374,6 +374,18 @@ module.exports = function(grunt) {
           'tmp/mangle.js': ['test/fixtures/src/simple.js']
         },
         mangle: true
+      },
+      beautify_Object: {
+        files: {
+          'tmp/beautify.js': ['test/fixtures/src/localization.js', 'test/fixtures/src/simple.js']
+        },
+        options: {
+          beautify: {
+            'ascii_only': true,
+            'indent_start': 2,
+            'max_line_len': 40
+          }
+        }
       }
     },
 

diff --git a/tasks/lib/uglify.js b/tasks/lib/uglify.js
@@ -220,16 +220,6 @@ exports.init = function(grunt) {
       outputOptions.preamble = options.banner;
     }
 
-    if (options.beautify) {
-      if (_.isObject(options.beautify)) {
-        // beautify options sent as an object are merged
-        // with outputOptions and passed to the OutputStream
-        _.assign(outputOptions, options.beautify);
-      } else {
-        outputOptions.beautify = true;
-      }
-    }
-
     if (options.screwIE8) {
       outputOptions.screw_ie8 = true;
     }
@@ -277,6 +267,14 @@ exports.init = function(grunt) {
       outputOptions.comments = options.preserveComments;
     }
 
+    if (options.beautify) {
+      if (_.isObject(options.beautify)) {
+        _.assign(outputOptions, options.beautify);
+      } else {
+        outputOptions.beautify = true;
+      }
+    }
+
     return outputOptions;
   };
 

diff --git a/test/fixtures/expected/beautify.js b/test/fixtures/expected/beautify.js
diff --git a/test/uglify_test.js b/test/uglify_test.js
@@ -12,6 +12,7 @@ exports.contrib_uglify = {
   preuglified_files: function(test) {
 
     var files = [
+      'beautify.js',
       'comments.js',
       'compress.js',
       'compress_explicit.js',