Rethrow the compilation error after printing the message.

[fatfisz]

Fixes #314

I wanted to sign the CLA, but I don't know what would The Dojo Foundation need my address for 😕 Is there any other way in which we can move forward?

[XhmikosR]

Shouldn't we use grunt.log instead of throw?

Also, can you add a test case?

[fatfisz]

Sorry, forgot to respond.

If we only grunt.log error, the compiled.push(output.css); line will still throw. I think that rethrowing in this case and passing the error to the rejection handler (function(err) { nextFileObj(err); }) is the best option.

About the logging thing, doesn't less itself log something? I don't remember rn, will check tomorrow.

About the test case: I will add it soon.

[fatfisz]

I've checked what's happening with the logs and lessError(err, srcFile) already takes care of that.

So the error is logged, the problem is with the swallowed exception.

[fatfisz]

I've added a test, but it requires a bit of an explanation, I guess.

Because the whole task code is kept in one file, unit testing is impossible. Therefore for the test I've decided to rely on the fail.report Grunt method that prints either Done, but with warnings. or Done.. When control is not returned to Grunt, this method is not called and so the Done word is never printed (which is what happens now).

Also the --force flag needs to be passed in the test because otherwise grunt.fail.warn in lessError will cause an abrupt stop and make testing impossible.

[XhmikosR]

Can't you just specify force for this one specific task in Gruntfile?

[fatfisz]

I don't understand? It's already specified in the test.

[XhmikosR]

Without going to all this trouble and doing all kind of hacks like renaming the task, which is something I certainly don't like myself.

[fatfisz]

Oh, about that - I wanted to exclude the erroring task from the rest of the batch. If you are not convinced, I could use the force indeed.

[XhmikosR]

I think it will be cleaner; just force that one specific task.

[fatfisz]

Ok, will do that in a few hours or so (I'm still at work).

[fatfisz]

I got lost; how can I force only one task? gruntjs/grunt#810 is still open, only workarounds exist and not a built-in solution. Wat do?

[XhmikosR]

@fatfisz: did you try passing force: true in the specific subtask's options?

[fatfisz]

Tried it, not working.

[fatfisz]

(also tried with passing force: true not in the options property, but directly, with the same result)