Skip to content

Commit

Permalink
Update CI configs
Browse files Browse the repository at this point in the history
  • Loading branch information
shama committed Jan 30, 2016
1 parent 1ecb72c commit e950787
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 3 deletions.
14 changes: 11 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
sudo: false
language: node_js
node_js:
- '5'
- '4'
- '0.10'
- "0.10"
- "0.12"
- "4"
- "5"
- "iojs"
before_install:
- npm install -g npm
before_script:
- npm install -g grunt-cli
matrix:
fast_finish: true
32 changes: 32 additions & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Fix line endings on Windows
init:
- git config --global core.autocrlf true
# What combinations to test
environment:
matrix:
- nodejs_version: "0.10"
- nodejs_version: "0.12"
- nodejs_version: "4"
- nodejs_version: "5"
platform:
- x86
- x64
install:
- ps: Install-Product node $env:nodejs_version
- npm install -g npm
- npm install -g grunt-cli
- npm install
test_script:
# Output useful info for debugging.
- node --version && npm --version
# We test multiple Windows shells because of prior stdout buffering issues
# filed against Grunt. https://github.com/joyent/node/issues/3584
- ps: "npm test # PowerShell" # Pass comment to PS for easier debugging
- cmd: npm test
build: off
matrix:
fast_finish: true
cache:
- C:\Users\appveyor\AppData\Roaming\npm\node_modules -> package.json # global npm modules
- C:\Users\appveyor\AppData\Roaming\npm-cache -> package.json # npm cache
- node_modules -> package.json # local npm modules

5 comments on commit e950787

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shama: do we really need 0.12? Also, the AppVeyor config you used is slightly off, there are no global packages to cache.

@shama or @vladikoff: can you add AppVeyor for this repository?

@vladikoff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shama
Copy link
Member Author

@shama shama commented on e950787 Feb 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XhmikosR Why not test on 0.12?

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shama: isn't 0.12 superseded by 4 which is LTS? 0.10 makes sense to test as the minimum supported version, 4 as the LTS and 5 as the latest one.

@shama
Copy link
Member Author

@shama shama commented on e950787 Feb 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XhmikosR 0.12 and 4 are completely different versions and more importantly completely different versions of V8. I want to test on all the versions we plan on supporting. 0.12 probably doesn't have as many users as 0.10 or 4 but a significant enough to test to at least know if we broke something in that version. Much easier to see the commit where it broke rather than chasing down a user bug report.

Please sign in to comment.