Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve multiple sourcemap concatenation #156

Merged
merged 2 commits into from
Apr 20, 2016
Merged

Resolve multiple sourcemap concatenation #156

merged 2 commits into from
Apr 20, 2016

Conversation

leigeber
Copy link
Contributor

Create central, single sourcemap RegEx variable
Ensure no empty comments remain after sourceMapppingURL removal

This should resolve #155

@leigeber
Create central, single sourcemap RegEx variable
8884aef 
Ensure no empty comments remain after sourceMapppingURL removal
@XhmikosR
Copy link
Member

Please make sure tests pass.

@leigeber
Copy link
Contributor Author

@XhmikosR Sure thing, I've updated the expectation file since the sourcemap comments are no longer replaced with an empty newline.

@XhmikosR
Copy link
Member

Ping @shama

@shama shama merged commit e8577c5 into gruntjs:master Apr 20, 2016
@shama
Copy link
Member

shama commented Apr 20, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concatenating multiple files with sourcemaps
3 participants
@leigeber @XhmikosR @shama