New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TokenFetcherCredentials] add backoff and pre-fetching #37531

Closed

markdroth wants to merge 39 commits into grpc:master from markdroth:token_fetcher_call_creds_prefetch_and_backoff

Member

markdroth commented Aug 19, 2024 •

edited

Loading

This adds functionality that is intended to be used for the new GcpServiceAccountIdentityCallCredentials implementation, as per gRFC A83 (grpc/proposal#438). However, it is also a useful improvement for all token-fetching call credentials types, so I am adding it to the base class.

markdroth and others added 18 commits

July 11, 2024 15:46


          TokenFetcherCredentials base class

7630a7c


          implement Oauth2TokenFetcher


          migrate grpc_google_refresh_token_credentials


          migrate grpc_compute_engine_token_fetcher_credentials

3666a36


          migrated StsTokenFetcherCredentials

7bd7f30


          rework interfaces a bit

85a2aa3


          use DualRefCounted<> for call creds

eb81372


          minor tweaks

aab3b73


          WIP on external account creds

724255f


          Merge remote-tracking branch 'upstream/master' into gcp_service_accou…

dbda67d

…nt_identity_call_creds


          tests working

798fb55


          Merge remote-tracking branch 'upstream/master' into gcp_service_accou…

c35ea49

…nt_identity_call_creds


          remove old code

6e13580


          don't hold unnecessary ref

9dcdcbe


          fix test

a90942c


          sanity

ea42b39


          Automated change: Fix sanity tests

4beee1f


          [TokenFetcherCredentials] add backoff and pre-fetching

267e854

markdroth added the release notes: no label

github-actions bot added the lang/core label

grpc-checks bot added bloat/medium per-call-memory/decrease per-channel-memory/neutral labels

markdroth added 7 commits

August 19, 2024 19:41


          drain fuzzing EE before shutting down

f3a5c6e


          Token class does not need to be virtual

eb9fd47


          Merge branch 'token_fetcher_call_creds_refactor' into token_fetcher_c…

07dcdfa

…all_creds_prefetch_and_backoff


          started adding tests

bcbd368


          clang-tidy


          try another fix for fuzzing EE on macos

e14e7df


          Merge branch 'token_fetcher_call_creds_refactor' into token_fetcher_c…

b2da19a

…all_creds_prefetch_and_backoff

markdroth added 2 commits

August 22, 2024 21:07


          Merge remote-tracking branch 'upstream/master' into token_fetcher_cal…

…l_creds_prefetch_and_backoff


          fix fuzzing EE usage

443ea2f

grpc-checks bot added per-call-memory/increase and removed per-call-memory/neutral labels


          Merge remote-tracking branch 'upstream/master' into token_fetcher_cal…

0fcdb48

…l_creds_prefetch_and_backoff

markdroth marked this pull request as ready for review

August 23, 2024 00:55

markdroth requested a review from matthewstevenson88

August 23, 2024 00:55

grpc-checks bot added per-call-memory/neutral and removed per-call-memory/increase labels

matthewstevenson88 approved these changes

View reviewed changes

copybara-service bot closed this in

158976a

markdroth added a commit to markdroth/grpc that referenced this pull request


          Revert "[TokenFetcherCredentials] add backoff and pre-fetching (grpc#…

3701b84

…37531)"

This reverts commit 158976a.

markdroth mentioned this pull request

[call creds] revert #37544 and #37531 #37567

Closed

copybara-service bot pushed a commit that referenced this pull request


          [call creds] revert #37544 and #37531 (#37567)

a615c50

The changes in #37531 are causing test failures under run_tests.py (but not bazel), and #37544 was built on top of #37531, so both need to be reverted.

Closes #37567

COPYBARA_INTEGRATE_REVIEW=#37567 from markdroth:call_creds_revert d086e06
PiperOrigin-RevId: 666978406

markdroth added a commit to markdroth/grpc that referenced this pull request


          Revert "[call creds] revert grpc#37544 and grpc#37531 (grpc#37567)"

8b77b62

This reverts commit a615c50.

paulosjca pushed a commit to paulosjca/grpc that referenced this pull request


          [TokenFetcherCredentials] add backoff and pre-fetching (grpc#37531)

d4eeefd

This adds functionality that is intended to be used for the new GcpServiceAccountIdentityCallCredentials implementation, as per gRFC A83 (grpc/proposal#438).  However, it is also a useful improvement for all token-fetching call credentials types, so I am adding it to the base class.

Closes grpc#37531

COPYBARA_INTEGRATE_REVIEW=grpc#37531 from markdroth:token_fetcher_call_creds_prefetch_and_backoff 0fcdb48
PiperOrigin-RevId: 666809903

paulosjca pushed a commit to paulosjca/grpc that referenced this pull request


          [call creds] revert grpc#37544 and grpc#37531 (grpc#37567)

b8bf7ea

The changes in grpc#37531 are causing test failures under run_tests.py (but not bazel), and grpc#37544 was built on top of grpc#37531, so both need to be reverted.

Closes grpc#37567

COPYBARA_INTEGRATE_REVIEW=grpc#37567 from markdroth:call_creds_revert d086e06
PiperOrigin-RevId: 666978406

copybara-service bot pushed a commit that referenced this pull request


          Revert "[call creds] revert #37544 and #37531 (#37567)" (#37573)

fc8ab2b

The first commit is a pure revert of the revert, and the second one has the fix.

Closes #37573

COPYBARA_INTEGRATE_REVIEW=#37573 from markdroth:call_creds_roll_forward 2476329
PiperOrigin-RevId: 667672832

paulosjca pushed a commit to paulosjca/grpc that referenced this pull request


          Revert "[call creds] revert grpc#37544 and grpc#37531 (grpc#37567)" (g…

a56f884

…rpc#37573)

The first commit is a pure revert of the revert, and the second one has the fix.

Closes grpc#37573

COPYBARA_INTEGRATE_REVIEW=grpc#37573 from markdroth:call_creds_roll_forward 2476329
PiperOrigin-RevId: 667672832

eugeneo pushed a commit to eugeneo/grpc that referenced this pull request


          [TokenFetcherCredentials] add backoff and pre-fetching (grpc#37531)

ab8cf91

This adds functionality that is intended to be used for the new GcpServiceAccountIdentityCallCredentials implementation, as per gRFC A83 (grpc/proposal#438).  However, it is also a useful improvement for all token-fetching call credentials types, so I am adding it to the base class.

Closes grpc#37531

COPYBARA_INTEGRATE_REVIEW=grpc#37531 from markdroth:token_fetcher_call_creds_prefetch_and_backoff 0fcdb48
PiperOrigin-RevId: 666809903

eugeneo pushed a commit to eugeneo/grpc that referenced this pull request


          [call creds] revert grpc#37544 and grpc#37531 (grpc#37567)

0fa03ae

The changes in grpc#37531 are causing test failures under run_tests.py (but not bazel), and grpc#37544 was built on top of grpc#37531, so both need to be reverted.

Closes grpc#37567

COPYBARA_INTEGRATE_REVIEW=grpc#37567 from markdroth:call_creds_revert d086e06
PiperOrigin-RevId: 666978406

eugeneo pushed a commit to eugeneo/grpc that referenced this pull request


          Revert "[call creds] revert grpc#37544 and grpc#37531 (grpc#37567)" (g…

a7c2d7c

…rpc#37573)

The first commit is a pure revert of the revert, and the second one has the fix.

Closes grpc#37573

COPYBARA_INTEGRATE_REVIEW=grpc#37573 from markdroth:call_creds_roll_forward 2476329
PiperOrigin-RevId: 667672832

markdroth mentioned this pull request

[call-v3] Migrate time caching to the right spot #37637

Closed

sourabhsinghs pushed a commit to sourabhsinghs/grpc that referenced this pull request


          [TokenFetcherCredentials] add backoff and pre-fetching (grpc#37531)

d7da0c5

This adds functionality that is intended to be used for the new GcpServiceAccountIdentityCallCredentials implementation, as per gRFC A83 (grpc/proposal#438).  However, it is also a useful improvement for all token-fetching call credentials types, so I am adding it to the base class.

Closes grpc#37531

COPYBARA_INTEGRATE_REVIEW=grpc#37531 from markdroth:token_fetcher_call_creds_prefetch_and_backoff 0fcdb48
PiperOrigin-RevId: 666809903

sourabhsinghs pushed a commit to sourabhsinghs/grpc that referenced this pull request


          [call creds] revert grpc#37544 and grpc#37531 (grpc#37567)

2b1868f

The changes in grpc#37531 are causing test failures under run_tests.py (but not bazel), and grpc#37544 was built on top of grpc#37531, so both need to be reverted.

Closes grpc#37567

COPYBARA_INTEGRATE_REVIEW=grpc#37567 from markdroth:call_creds_revert d086e06
PiperOrigin-RevId: 666978406

sourabhsinghs pushed a commit to sourabhsinghs/grpc that referenced this pull request


          Revert "[call creds] revert grpc#37544 and grpc#37531 (grpc#37567)" (g…

9b343f7

…rpc#37573)

The first commit is a pure revert of the revert, and the second one has the fix.

Closes grpc#37573

COPYBARA_INTEGRATE_REVIEW=grpc#37573 from markdroth:call_creds_roll_forward 2476329
PiperOrigin-RevId: 667672832

paulosjca pushed a commit to paulosjca/grpc that referenced this pull request


          [TokenFetcherCredentials] add backoff and pre-fetching (grpc#37531)

d4a98a9

This adds functionality that is intended to be used for the new GcpServiceAccountIdentityCallCredentials implementation, as per gRFC A83 (grpc/proposal#438).  However, it is also a useful improvement for all token-fetching call credentials types, so I am adding it to the base class.

Closes grpc#37531

COPYBARA_INTEGRATE_REVIEW=grpc#37531 from markdroth:token_fetcher_call_creds_prefetch_and_backoff 0fcdb48
PiperOrigin-RevId: 666809903

paulosjca pushed a commit to paulosjca/grpc that referenced this pull request


          [call creds] revert grpc#37544 and grpc#37531 (grpc#37567)

cc1a8d5

The changes in grpc#37531 are causing test failures under run_tests.py (but not bazel), and grpc#37544 was built on top of grpc#37531, so both need to be reverted.

Closes grpc#37567

COPYBARA_INTEGRATE_REVIEW=grpc#37567 from markdroth:call_creds_revert d086e06
PiperOrigin-RevId: 666978406

paulosjca pushed a commit to paulosjca/grpc that referenced this pull request


          Revert "[call creds] revert grpc#37544 and grpc#37531 (grpc#37567)" (g…

25b8016

…rpc#37573)

The first commit is a pure revert of the revert, and the second one has the fix.

Closes grpc#37573

COPYBARA_INTEGRATE_REVIEW=grpc#37573 from markdroth:call_creds_roll_forward 2476329
PiperOrigin-RevId: 667672832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/medium lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no