-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using native maven_jar rule in grpc #5327
Conversation
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Does Google have a corporate CLA for linuxfoundation or should I join as an individual? |
I mailed this internally, so I'm closing the PR |
Reopened and joined the google github org for the CLA |
ping CLA |
Google has a corporate CLA. @dkelmer, how was this generated? To get the licenses right it seems there was some tool. |
I must admit that I manually googled the jars individually and copied the license information from maven central to the bzl file |
@dkelmer, oh, in that case thank you for all the effort. Have you gone through the process for the CLA? I think you need github to know associate your |
ping CLA |
You're welcome :)
I think I just did it |
Yay! The CLA is happy. I forgot to trigger the Kokoro builds earlier. After they finish I'll merge. |
Seems like kokoro passed :) |
@dkelmer, thank you! |
See bazelbuild/bazel#6799 for more information