Resolve drift in Netty http/2 apis. #4
Conversation
|
If you could also update the lib/netty submodule to the commit you are basing this work, that would be helpful (either HEAD or Nathan's commit). We are definitely interested in inbound flow control, but it also seems like you ported over our usage of it. Did you mean outbound flow control? If so, then the answer is "yes, but not yet." We haven't yet figured out the method name/API for exposing outbound flow control to applications in the Call/ServerCall class. We actually had an idea of how we wanted it to look, but couldn't quite decide on a name. There is now a conversation of changing flow control to look more like reactive-streams, which would also impact the interface. We will certainly want to provide outbound flow control feedback to the application, but we don't yet know concretely what that will look like. |
|
ok updated to HEAD and fixed tests |
|
@ejona86 should we cherrypick, or are we waiting on something? |
|
We can cherrypick. |
|
@adriancole would you mind rebasing against the latest head? I'll be happy to cherry-pick when you're ready. Thanks! |
|
ok, but don't merge yet. This will fail tests until netty/netty#3348 is in and my commit resets the netty sha accordingly. |
|
@adriancole sgtm, thanks! |
|
okie ready to go. |
|
Cherry-picked as c4a43e6 Thanks @adriancole! :) |
Update grpc core to use new OpenCensus API.
Fixes api drift, addressing inbound flow control.