Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize number of DATA frames for unary requests #34

Merged
merged 1 commit into from
Jan 23, 2015
Merged

Optimize number of DATA frames for unary requests #34

merged 1 commit into from
Jan 23, 2015

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jan 22, 2015

Resolves #10

@nmittler
Copy link
Member

@ejona86 LGTM ... feel free to cherry-pick!

codefromthecrypt
codefromthecrypt reviewed Jan 23, 2015
View reviewed changes
core/src/main/java/com/google/net/stubby/ChannelImpl.java
@@ -308,7 +311,12 @@ public void sendPayload(ReqT payload) {
cancel();
}
}
stream.flush();
// For unary requests, we don't flush since we know that halfClose should be coming soon. This
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sensible

@codefromthecrypt
Copy link
Contributor

LGTM

@ejona86 ejona86 merged commit ada32b0 into grpc:master Jan 23, 2015
@ejona86 ejona86 deleted the optimize-unary branch January 23, 2015 01:47
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unary requests always send an empty DATA frame with EOS=true to close stream
3 participants
@ejona86 @nmittler @codefromthecrypt